Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize #88

Closed
wants to merge 12 commits into from
Closed

Modernize #88

wants to merge 12 commits into from

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Oct 29, 2023 •
edited
Loading

This PR takes care of some minor issues that I've ran into that are a result of either newer ghc or newer dependency

Also usage of unsafeSTToPrim was uncalled for, there was nothing unsafe there. Switched to stToPrim

This PR discovered some sort of linker issue with doctests on newer MacOS, which unfortunately I have no idea how to fix:

System/Random/MWC.hs:30: failure in expression `g <- createSystemRandom'
expected: 
 but got: ld: warning: -undefined dynamic_lookup may not work with chained fixups
          ^

Examples: 33  Tried: 8  Errors: 0  Failures: 1

@lehins lehins force-pushed the lehins/modernize branch 3 times, most recently from 9ca0409 to 981af1a Compare October 29, 2023 22:48
@lehins lehins mentioned this pull request Nov 24, 2023
Open
Shimuuar added a commit that referenced this pull request May 9, 2024
@Shimuuar
Merge pull request #92 from Shimuuar/chery-picking
d37e6f6 
Cherry picked commits from #88
@Shimuuar
Copy link
Collaborator

Shimuuar commented May 9, 2024

Sorry I forgot about this PR. Some problems I fixed independently while updating benchmarks and rest are cherry-picked in #92.

@Shimuuar Shimuuar closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @Shimuuar